Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AWS Rekognition Node): Fix all different action type #6136

Merged
merged 6 commits into from
May 4, 2023

Conversation

agobrech
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/amazon-rekognition-node-issue/16766

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 36.84% and project coverage change: +0.08 🎉

Comparison is base (3074f42) 19.97% compared to head (953a5b6) 20.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6136      +/-   ##
==========================================
+ Coverage   19.97%   20.06%   +0.08%     
==========================================
  Files        2621     2622       +1     
  Lines      118071   118087      +16     
  Branches    18520    18556      +36     
==========================================
+ Hits        23585    23691     +106     
+ Misses      93774    93681      -93     
- Partials      712      715       +3     
Impacted Files Coverage Δ
...-base/nodes/Aws/Rekognition/AwsRekognition.node.ts 46.66% <36.84%> (+46.66%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 28, 2023
maspio
maspio previously approved these changes May 4, 2023
Copy link
Contributor

@maspio maspio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@maspio maspio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me again. Forgot to push console.log fix. 😄

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

✅ All Cypress E2E specs passed

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

✅ All Cypress E2E specs passed

@agobrech agobrech merged commit 22b82a4 into master May 4, 2023
@agobrech agobrech deleted the node-37-aws-rekognition-empty-response-data- branch May 4, 2023 12:34
MiloradFilipovic added a commit that referenced this pull request May 5, 2023
* master: (110 commits)
  fix(editor): Update and add design system checkbox component to Editor (#6178)
  fix(editor): Display SSO entry in Settings on Cloud (#6181)
  feat(Code Node): Add Python support (#4295)
  fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180)
  feat(Kafka Trigger Node): Add non-parallel execution (#6175)
  fix(Postgres Node): Always return TIMESTAMP and TIMESTAMPZ as ISO string (#6145)
  fix: Revert change that hid the SSH private key (no-changelog) (#6158)
  fix(Google Sheets Node): Upgrade xlsx to address CVE-2023-30533 (#6172)
  fix(editor): Show the correct actions count in the nodes list (#6183)
  ci: Revert full db reset for e2e (no-changelog) (#6182)
  fix(AWS Rekognition Node): Fix all different action type (#6136)
  feat(Airtable Node): Access token support (#6160)
  fix(editor): Remove duplicate mapping of `item.json` key in data pinning (#6135)
  fix(HTTP Request Node): Correctly doesn't redirect on non GET method (#6132)
  fix(MySQL Node): Node should return date types as strings (#6169)
  feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171)
  🚀 Release 0.227.0 (#6167)
  fix(editor): Flag issues only on workflow activation (#6127)
  fix(editor): Faster reconnects for push (no-changelog) (#6164)
  fix: Log unhandled errors during license activation (no-changelog) (#6165)
  ...

# Conflicts:
#	packages/editor-ui/src/mixins/workflowHelpers.ts
#	packages/editor-ui/src/views/NodeView.vue
netroy pushed a commit that referenced this pull request May 15, 2023
* Fix broken logic with type action

* Unit test base

* Add unit test using only nock

* Fix failing test

* remove console log

---------

Co-authored-by: Marcus <marcus@n8n.io>
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.228.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants